search

dftlibs / xcfun

XCFun: A library of exchange-correlation functionals with arbitrary-order derivatives
https://dftlibs.org/xcfun/
Mozilla Public License 2.0
58 stars 32 forks source link

Drop Python 2.7 from CI jobs #104

Closed robertodr closed 4 years ago

robertodr commented 4 years ago

I have simplified the CI set up to only run on recent compilers. Older compilers can always be brought back at a later time. Close #103 Plus update the license year in the source files.

Status

robertodr commented 4 years ago

Downloading GCC on macOS "breaks" Python (meaning that Python 3 is not properly put on PATH by HomeBrew) I'm tempted to drop the build. Suggestions welcome.

bast commented 4 years ago

Is the problem the GCC part or the Python 3 part on macOS builds?

robertodr commented 4 years ago

When I install GCC, also Python is reinstalled/updated and then HomeBrew will not overwrite the links to Python 2.7 Thus, to Pipenv it looks like I have no Python 3 available...

bast commented 4 years ago

Not sure what to say here. It would be nice to have macOS builds but neither do I have the time to struggle with that now, nor do I want to expect that time investment from others.

robertodr commented 4 years ago

One macOS builds would remain, so we won't be completely uncovered. And honestly given how slow the macOS builders are on Travis, I'd rather invest effort in porting macOS to Azure Pipelines...

Conclusion: I'm removing the failing one.

robertodr commented 4 years ago

When this is green, reviewed, and approved, please squash-merge it.

codecov-io commented 4 years ago

Codecov Report

Merging #104 into master will increase coverage by 3.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   49.46%   52.49%   +3.02%     
==========================================
  Files          77       78       +1     
  Lines        1785     1922     +137     
==========================================
+ Hits          883     1009     +126     
- Misses        902      913      +11
Impacted Files Coverage Δ
src/functionals/pz81c.hpp 76.92% <ø> (ø) :arrow_up:
src/functionals/tpssx.cpp 100% <ø> (ø) :arrow_up:
src/functionals/revtpssc.cpp 0% <ø> (ø) :arrow_up:
src/functionals/m06hfc.cpp 0% <ø> (ø) :arrow_up:
src/functionals/m05x2x.cpp 100% <ø> (ø) :arrow_up:
src/functionals/pbeintx.cpp 0% <ø> (ø) :arrow_up:
src/functionals/m06lx.cpp 100% <ø> (ø) :arrow_up:
src/functionals/m06x.cpp 0% <ø> (ø) :arrow_up:
src/functionals/b97-1xc.cpp 0% <ø> (ø) :arrow_up:
src/functionals/pbex.hpp 70% <ø> (ø) :arrow_up:
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd662ae...31034ff. Read the comment docs.