search

dftlibs / xcfun

XCFun: A library of exchange-correlation functionals with arbitrary-order derivatives
https://dftlibs.org/xcfun/
Mozilla Public License 2.0
58 stars 32 forks source link

Handle 64-bit integers in Fortran properly #116

Closed robertodr closed 4 years ago

robertodr commented 4 years ago

This fixes compiler errors when setting default integer size to 64-bit in Fortran hosts.

Just a comment. I don't understand why the use of 64-bit integers in Fortran is a thing. But it poses an undue burden on library developers. And it is not fun. To any developer of a Fortran host to XCFun: this one commit is one hour of my life I will never get back.

bast commented 4 years ago

Looking at it and I agree with the comment.

foeroyingur commented 4 years ago

Lots of problems in the host program as well... Btw there is nothing preventing library developers from sticking to 32-bit integers? Just have to make the proper conversion in the interface in the host program.

bast commented 4 years ago

I agree but often it's the same poor souls who have to do the work.