search

dftlibs / xcfun

XCFun: A library of exchange-correlation functionals with arbitrary-order derivatives
https://dftlibs.org/xcfun/
Mozilla Public License 2.0
57 stars 32 forks source link

Fix potential array overflow in brx.cpp #153

Closed susilehtola closed 3 years ago

susilehtola commented 3 years ago

Closes #151

codecov-commenter commented 3 years ago

Codecov Report

Merging #153 (bea42e0) into master (f87ca0e) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   50.42%   50.42%           
=======================================
  Files          89       89           
  Lines        2334     2334           
=======================================
  Hits         1177     1177           
  Misses       1157     1157
Impacted Files Coverage Δ
src/functionals/brx.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f87ca0e...bea42e0. Read the comment docs.

robertodr commented 3 years ago

Thanks. We're putting this on hold until we can reproduce the warning and understand its origin (see my last comment in the issue) I would also prefer that the problematic situation be excluded with a compiler-time enable_if, rather than a run-time check.

robertodr commented 3 years ago

Superseded by #154. Closing.