robertodr commented 3 years ago

Description

This should fix #151. It makes sure that in BR_taylor the temporary taylor<T, 1, Ndeg> is always of Ndeg >= 3, such that the array subscript operations don't overflow.

How Has This Been Tested?

It has not. This functional is untested.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Status

[X] Ready to go

codecov-commenter commented 3 years ago

Codecov Report

Merging #154 (5d37981) into master (f87ca0e) will decrease coverage by 0.02%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   50.42%   50.40%   -0.03%     
==========================================
  Files          89       89              
  Lines        2334     2335       +1     
==========================================
  Hits         1177     1177              
- Misses       1157     1158       +1

Impacted Files	Coverage Δ
src/functionals/brx.cpp	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f87ca0e...5d37981. Read the comment docs.

bast commented 3 years ago

Thanks for the fix and sorry for the wait!

bast commented 3 years ago

The windows runners are waiting forever. OK if I merge anyway?