search

dftlibs / xcfun

XCFun: A library of exchange-correlation functionals with arbitrary-order derivatives
https://dftlibs.org/xcfun/
Mozilla Public License 2.0
57 stars 32 forks source link

make sure XC_MAX_ORDER is never undefined; fixes #35 #36

Closed bast closed 6 years ago

bast commented 6 years ago

If this is not there, compilation is broken and you get very strange errors from badly interpreted macros.

robertodr commented 6 years ago

Wasn't this fixed with #29 already? Anyway, I think fully switching to CMake will cure a lot of these problems.

On Dec 18, 2017 10:36, "Radovan Bast" notifications@github.com wrote:

@bast https://github.com/bast requested your review on: dftlibs/xcfun#36 https://github.com/dftlibs/xcfun/pull/36 make sure XC_MAX_ORDER is never undefined; fixes #35 https://github.com/dftlibs/xcfun/issues/35.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/dftlibs/xcfun/pull/36#event-1392342000, or mute the thread https://github.com/notifications/unsubscribe-auth/ADiXEbGejItgl3QmzksGHTwJVM7KxtNCks5tBoZfgaJpZM4RFpaw .

bast commented 6 years ago

Well, #29 broke what this one is fixing :-) Before #29, the parameter was not undefined. Now it is if you just clone XCFun and try to build it on its own.

bast commented 6 years ago

And we didn't notice then because the testing is a red sea. But I am now working on restoring the testing and then updating the docs.