search

dftlibs / xcfun

XCFun: A library of exchange-correlation functionals with arbitrary-order derivatives
https://dftlibs.org/xcfun/
Mozilla Public License 2.0
58 stars 32 forks source link

update comments in enum xc_vars; fixes #45 #47

Closed bast closed 6 years ago

bast commented 6 years ago

Order was not changed but hopefully it is now clearer what these represent.

bast commented 6 years ago

Please review @ilfreddy.

bast commented 6 years ago

OK I will add more documentation to each line.

ilfreddy commented 6 years ago

Wait a bit... new "user friendly" routine coming soon. You might want to add the documentation to that one instead.

bast commented 6 years ago

Is this PR possibly conflicting with yours?

ilfreddy commented 6 years ago

Nope :-)

bast commented 6 years ago

How about I merge it then? We can always add more stuff later but slightly better and merged is perhaps better than perfect and not finished (here I speak about the docs).

ilfreddy commented 6 years ago

You can go ahead for my part.

bast commented 6 years ago

OK - merging, we will improve later but I like to have less open things.