dftlibs / xcfun

XCFun: A library of exchange-correlation functionals with arbitrary-order derivatives
https://dftlibs.org/xcfun/
Mozilla Public License 2.0
57 stars 32 forks source link

Fortran support becomes optional, default: --fc-support=on #65

Closed bast closed 6 years ago

bast commented 6 years ago

If the code is configured with Fortran support, the Fortran bindings are tested.

This change also makes it possible to select the Fortran compiler via the setup line.

bast commented 6 years ago

Sorry this is not correct yet, I need to change the Appveyor recipe.

codecov-io commented 6 years ago

Codecov Report

Merging #65 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   42.29%   42.29%           
=======================================
  Files          78       78           
  Lines        1785     1785           
=======================================
  Hits          755      755           
  Misses       1030     1030

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e3fe55...6dab01c. Read the comment docs.

bast commented 6 years ago

Contrary to what I recommended in #62, Fortran support is ON by default and now sleeping on it I think it's fine. If you think this is not what we want, I can change that.

robertodr commented 6 years ago

I think this it should be OFF by default. This is a C++ code with optional Fortran bindings. If I want to use it in a C++ code and I have no idea about Fortran at all, it is going to be very surprising to see stuff fail because of a component I don't need.

bast commented 6 years ago

OK I will change to OFF.