make it possible to set XC_MAX_ORDER from outside; fixes #6

dftlibs / xcfun

XCFun: A library of exchange-correlation functionals with arbitrary-order derivatives

https://dftlibs.org/xcfun/

Mozilla Public License 2.0

57 stars 32 forks source link

make it possible to set XC_MAX_ORDER from outside; fixes #6 #8

Closed bast closed 8 years ago

bast commented 8 years ago

Can be done with:

$ cmake -DXC_MAX_ORDER=3 ..

If nothing is specified, max order defaults to 2 also with Makefiles which do not set this.

bast commented 8 years ago

@uekstrom can you please review and possibly integrate this?

uekstrom commented 8 years ago

I am not 100% sure that having an include file that depends on command line parameters is a good idea, but in this case I suppose it's ok.

2016-02-18 8:22 GMT+01:00 Radovan Bast notifications@github.com:

@uekstrom https://github.com/uekstrom can you please review and possibly integrate this?

— Reply to this email directly or view it on GitHub https://github.com/dftlibs/xcfun/pull/8#issuecomment-185576672.