dftlibs / xcfun

XCFun: A library of exchange-correlation functionals with arbitrary-order derivatives

https://dftlibs.org/xcfun/

Mozilla Public License 2.0

57 stars 32 forks source link

workaround for pipenv install error; fixes #80 #81

Closed bast closed 5 years ago

bast commented 5 years ago

@stigrj @robertodr

codecov-io commented 5 years ago

Codecov Report

Merging #81 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   44.37%   44.37%           
=======================================
  Files          78       78           
  Lines        1839     1839           
=======================================
  Hits          816      816           
  Misses       1023     1023

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a6acce...7e0bfd6. Read the comment docs.

robertodr commented 5 years ago

Thanks for the fix! Would you mind trying this approach: https://github.com/dev-cafe/cmake-cookbook/blob/master/.travis.yml#L105-L115 We invalidate PYENV_ROOT and then fix the version of Python to its absolute location on the Travis worker. It could get hairy with Python 2 support though. OT question: should we deprecate Python 2? I am fine with dropping it completely as of right now, for the record.

chjacob-tubs commented 5 years ago

Unfortunately, I still rely on Python 2 support in XcFun for PyADF. This is on the ToDo list, but requires some significant work.

bast commented 5 years ago

As to PYENV_ROOT: I would recommend to do this in a separate PR. My todo list is not pretty and I cannot dedicate more time to this today.