search

dfu-rs / dfu-core

Sans IO core library (traits and tools) for DFU
16 stars 5 forks source link

Support both dfu 1.1 and dfuse protocols #20

Closed sjoerdsimons closed 1 year ago

sjoerdsimons commented 1 year ago

Split protocol specific data for both dfu and dfuse into their own enum variants and handle the differences. The IO implementation is now responsible for a reference to protocol specific data rather then providing a memory layout (which is only for dfuse).

To make that a bit simpler for IO implementations the code from dfu-libusb was integrated to do the differentiation between the protocols and the parsing of dfuse data.

Also add helpers for sending a detach request as well as a usb reset without having to pull out the IO objects

Fixes #17

Signed-off-by: Sjoerd Simons sjoerd@collabora.com

sjoerdsimons commented 1 year ago

Really love all your excellent work! heart_eyes

Would you be interested to join the maintenance team? There is very little activity so not much to do and having people help reducing the bus factor!

That question is a great compliment, but honestly i already have too many projects, so i doubt i can commit much if any time to it :) Fwiw once this is landed (and the related bits on dfu-libusb) i'll hopefully just become a happy user instead

cecton commented 1 year ago

Let me know when I can merge. This looks perfect :ok_hand: already

sjoerdsimons commented 1 year ago

Let me know when I can merge. This looks perfect ok_hand already

You can merge it as soon as you think it's good enough :)

cecton commented 1 year ago

oh you're on mastodon? haha