Design integration

[pyrsmk]

Hi,

I noticed that the "master" branch text cover the thin line which delimits the status bar. This is pretty ugly :s

Also, I think it could be nice to have a text before the branch as "Git branch: ", it'll be much more visible.

Greetings

[dfuenzalida]

Would you mind send me a screenshot to find how it looks for you? I've tried several themes and it doesn't look that bad :-) ... I'll be adding the "Git branch" label soon, but I need to read about how to do internationalization for these plugins (so it reads "Rama de Git:" on Spanish, etc.

[pyrsmk]

Here's the screenshot : http://i.i.imgur.com/8dk9g.jpg

Good luck for your i18n investigations :)

[dfuenzalida]

Thank you very much for the screenshot. I'll try to fix it in the next days. It's possibly adding the label on a container or something so it does not overflow the status bar, but my PyGTK skills are limited :-)

i18n does not seem hard either, I'll try to implement it after fixing the label issue.

Kind regards,

Denis

2011/5/15 pyrsmk < reply@reply.github.com>

Here's the (screenshot)[i.i.imgur.com/8dk9g.jpg].

Good luck for your i18n investigations :)

Reply to this email directly or view it on GitHub:

https://github.com/dfuenzalida/gedit-git-branch-statusbar/issues/1#comment_1166711

"Music is not the expression of a feeling, it's the feeling itself". -- Claude Debussy

[pyrsmk]

Ah, you make it by adding a label? Can't you just add a area directly into the statusbar?

[dfuenzalida]

Yep, just a label without a container:

    # Find the status bar, add a new label to show the branch
    status_bar = window.get_statusbar()
    self._branch_label = gtk.Label("")
    status_bar.add(self._branch_label)

So I think I must place the Label inside some container (not sure which, my PyGTK skills are not strong) so it does not overflow the status bar.

Kind regards,

Denis

2011/5/15 pyrsmk < reply@reply.github.com>

Ah, you make it by adding a label? Can't you just add a area directly into the statusbar?

Reply to this email directly or view it on GitHub:

https://github.com/dfuenzalida/gedit-git-branch-statusbar/issues/1#comment_1166889

"Music is not the expression of a feeling, it's the feeling itself". -- Claude Debussy

[dfuenzalida]

Hi!

Today I spent a while reading the PyGTK documentation and the gedit sources, so it seems it was OK to use a label, but it worked great if put inside a container (now I'm using a gtk.Frame) and packed everything in a different way, so I've updated it and pushed the new version to GitHub.

See screenshot: http://i.imgur.com/TY4YD.png

[pyrsmk]

And all works well, thanks a lot :)