v0.2.0 - Githubissues

dfuncd / repofuck

Fucking with the Repository Design Pattern

6 stars 2 forks source link

v0.2.0 #90

Open rmrhz opened 7 years ago

rmrhz commented 7 years ago

As version v0.1.* will be shelved by next year, the new version will put new improvements and backwards incompatibility as functions will be renamed. The list below will be updated in the coming days.

[x] Rename setKeys to keys
[x] Rename setData to data
[x] Rename data to fill
[x] #91 entity function to have a Callback parameter

makoru-hikage commented 7 years ago

Isn't it a bad practice to have a method that exactly spells like a property? (e.g. keys() and $keys)

rmrhz commented 7 years ago

It may be, but for this matter the method have two functions. If null, returns the keys, if defined by an array, defines the keys.

makoru-hikage commented 7 years ago

Anyway, the $ prefix is a giveaway.

If null, returns the keys, if defined by an array, defines the keys.

Feels like jQuery.

makoru-hikage commented 7 years ago

About the entities, I shall expect not even a getter and a setter. What is the purpose of the $repositories property?