search

dfurtado / dataclass-csv

Map CSV to Data Classes
Other
195 stars 21 forks source link

Add type hinting to external API #37

Closed SpamapS closed 3 years ago

SpamapS commented 3 years ago

This should allow dataclass-csv consumers to rely on type hinting more fully rather than ignoring the import as Any's.

We also check that our code remains type safe with mypy.

Note that flake8 doesn't work, who knows for how long, so we run mypy first since that is clean.

dfurtado commented 3 years ago

Hey Clint!

Thank you so much for sending this PR! 🙌

I will have a look at it later today.

SpamapS commented 3 years ago

Thanks for the review! Yeah I'll make the updates you ask for, glad to.

I was just checking in on this when you happened to review, so glad we're on it at the same time. :)

I'll take another pass later today. I think syncing with the typeshed stubs will be another good thing, I haven't looked closely as to how well I did that by reading docs and guessing. ;)

dfurtado commented 3 years ago

You're welcome! Thanks you, I really appreciate the contributions to this project!

SpamapS commented 3 years ago

FYI, I've been pulled in a different direction, so it will probably be a few days before I can make the requested changes. Thanks for your patience.

dfurtado commented 3 years ago

No worries @SpamapS there's no rush. I have some features that I will be working on before I create a new release. Thanks for letting me know.

dfurtado commented 3 years ago

Hello @SpamapS

I just wanted to hear how this PR is going? Is there anything I can do to help?