search

dg / bypass-finals

Removes `final` and `readonly` keywords from source code on-the-fly and allows mocking of final methods and classes. It can be used together with any test tool such as PHPUnit or Mockery.
Other
487 stars 30 forks source link

Updated stream_set_option signature #28

Closed bzikarsky closed 3 years ago

bzikarsky commented 3 years ago

The third argument has to be nullable. While the docs specify a signature lof public streamWrapper::stream_set_option ( int $option , int $arg1 , int $arg2 ) : bool they also say this: arg2: If option is STREAM_OPTION_BLOCKING: This option is not set.

The third argument has to be nullable. While the docs specify a signature lof public streamWrapper::stream_set_option ( int $option , int $arg1 , int $arg2 ) : bool they also say this: arg2: If option is STREAM_OPTION_BLOCKING: This option is not set.

We get errors like this TypeError: Argument 3 passed to DG\BypassFinals::stream_set_option() must be of the type int, null given because of this.

bzikarsky commented 3 years ago

Hm, the coding-style errors are not due to my change. Can I ignore those or can you fix those separately and I'll rebase?

dg commented 3 years ago

Thanks

bzikarsky commented 3 years ago

Thanks, would you be willing to soon tag a new version? :-) I'd rather have a stable reference in our dependencies.

dg commented 3 years ago

Yes, I just released it