dg / composer-cleaner

Victor The Cleaner: removes unnecessary files from vendor directory
https://nette.org
134 stars 19 forks source link

Maintaining a list of packages that needs to be ignored by default #22

Open Hemric opened 4 years ago

Hemric commented 4 years ago

Description

After having installed this package on my project and successfully passed tests. I end up catching (fortunately) an issue with a business important package stripe-php during e2e testing. The cleaner removes a folder called "data" which contains a "ca-certificates.crt" used by the library when actually calling the Stripe API ! The exception thrown end up notifying a Network Error that is uneasy to debug.

This could have been launched to production with a less rigorous testing and impact website badly.

Maybe we could put at least a feature that detects sensitive packages that needs to be ignored by default. And notifying user during install.

Steps To Reproduce