search

dg / composer-cleaner

Victor The Cleaner: removes unnecessary files from vendor directory
https://nette.org
134 stars 19 forks source link

Improvements #3

Closed JanTvrdik closed 9 years ago

dg commented 9 years ago

License file is on remote (production) server really useless.

hrach commented 9 years ago

just lol. github is also remote server, so i'm going to delete it. nette can lives without it on remote servers.

dg commented 9 years ago

Feel free to remove nette license on all your production servers.

JanTvrdik commented 9 years ago

The motivation for keeping license files is simple. I work on open-source projects with committed vendor directory (example). Removing licenses under this conditions is AFAIK not possible.

hrach commented 9 years ago

I wonder what was the purpose of this package at all. The only reason to use has been mentioned by Jan Tvrdik. Why should I remove this useless files on production servers? I really don't care. David, it's getting clear that you are not so experienced with using composer for the final products.

JanTvrdik commented 9 years ago

@hrach Keep calm and let me handle the discussion. Your insults are both stupid and annoying.

Why should I remove this useless files on production servers?

You may want to remove them locally before deploying to production. In that case you may not need license files as pointed out by @dg.

hrach commented 9 years ago

@JanTvrdik you are not right, the code has to be distributed always with it's licence, not matter how broad the audience is. Eg.

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

hrach commented 9 years ago

I would appreciate, if you both stop changing your posted comments without marking the changed parts.

JanTvrdik commented 9 years ago

if you both stop changing your posted comments without marking the changed parts

Sorry, I do this all the time. Mostly to fix typos and add clarity to reduce confusion.

dg commented 9 years ago

@hrach please go away

@JanTvrdik I am not commiting vendor (yes, it's bad, I know) so I did not think about this usage. In this case it makes sense to keep the license.

dg commented 9 years ago

Thanx!

dg commented 9 years ago

@JanTvrdik sometimes is vendor structure deeper (example), do you know why?

JanTvrdik commented 9 years ago

@dg Because of target-dir (doc). Yes, we should probably support that as well even though it is an deprecated option.