Fixed TalkerAlias - Embedded Data with Slot number

dg9vh / MMDVMHost-Dashboard

Dashboard for MMDVMHost (by G4KLX)

Creative Commons Zero v1.0 Universal

60 stars 45 forks source link

Fixed TalkerAlias - Embedded Data with Slot number #104

Closed pjao closed 7 years ago

pjao commented 7 years ago

@dg9vh please see https://github.com/g4klx/MMDVMHost/issues/268

After @g4klx accept it, you could also accept this one!

Also changed the version.

pjao commented 7 years ago

Also included a fix to one of my lasts PR that it give and error on syslog:

Fixing egrep command

Two and expressions with grep you need two invocations
No need also to use egrep again, grep it's ok

dg9vh commented 7 years ago

Could you give me a note here, if it is committed by Jonathan? I am vy busy at the moment and could not monitor him...

phl0 commented 7 years ago

I can do that. I need to analyze a possible regression for log level 1 before I can PR that to MMDVMHost.

dg9vh commented 7 years ago

@phl0 FileLevel = 1 is not recommended due to big logfiles and a great amount of time to process them. The logs would grow very fast to 30 or 40 Megabytes that is not ok for processing via PHP and so on. Therefore we prefer FileLevel = 2.

phl0 commented 7 years ago

Yes I know. But if my change to the code makes problems if the log level is set to 1 I must correct that. I do not want to make log level 1 useless though it is not used for the dashboard.

dg9vh commented 7 years ago

@phl0 cfm, now I understood :-)

pjao commented 7 years ago

Closing... Let's wait.