search

dg9vh / MMDVMHost-Dashboard

Dashboard for MMDVMHost (by G4KLX)
Creative Commons Zero v1.0 Universal
60 stars 45 forks source link

DSTAR 'target' spaces aren't correctly displayed #80

Closed m1geo closed 7 years ago

m1geo commented 7 years ago

On DSTAR, a target such as ' E' for echo test doesn't display right. The previous spaces are lost in the HTML.

These should be ' ' to protect the spaces.

Just something I noticed.

George M1GEO.

m1geo commented 7 years ago

Turns out that github also removes them!

'^^^^^^^E' where the carrat is a space.

And, replace with '& n b s c'

George. M1GEO.

phl0 commented 7 years ago

I currently cannot produce a log line by myself. Could you mail me one or make a screenshot pls?

phl0 commented 7 years ago

Made a small patch https://github.com/phl0/MMDVMHost-Dashboard/tree/devel to remove this. However due to not using a fixed width font this looks somewhat odd:

screenshot from 2017-01-16 18-13-21

I'll try a give it a go with a Courier font or the like.

dg9vh commented 7 years ago

Should we give text-align: right as style-element a try to make the cell right aligned?

phl0 commented 7 years ago

That would on the other hand look if you have a short callsign like yours or my one I guess because the left part should be left aligned.

dg9vh commented 7 years ago

@m1geo I do not really get the point, why it is necessary to display those information with 7 spaces in front of it? I think everybody who uses DSTAR know, that such commands are placed in the 8th position of the URCALL-Field so on the dashboard, that is for information purpose, in my eyes it is not necessary to follow all special needs, "the system" has to use... the 8th place is only relevant because the system does not take care about the first 7 positions... it's "per definition" to place commands on position 8...

@phl0 you are right... my idea was only to right align such special commands like E, I and U. But this is another problem that brings some ugly optic on the right border...

The problem could be solved by using a fixed width font... and replacing each space with a non breaking space... but this is another optical issue then... other font means other optical look and feel...

phl0 commented 7 years ago

Me thinks about giving a fixed-width font a try and then see what it looks like. It would make it easier to distinguish between E as command and someone using E as a callsign (which of course is obviously odd anyway)... That is why I did not merge my changes yet. The current change does not really look nicer than what the code gave before IMHO.

dg9vh commented 7 years ago

@phl0 just play a bit around - I actually got another job by wife - no time to do some programing, hi.

phl0 commented 7 years ago

Made another commit to my devel branch:

bildschirmfoto vom 2017-01-16 21-00-16

What do you think?

dg9vh commented 7 years ago

@phl0 I think, it looks ok :+1:

phl0 commented 7 years ago

Some more details with two modes.

bildschirmfoto vom 2017-01-16 23-04-50

m1geo commented 7 years ago

Sorry guys, for some reason, GitHub was not informing me of this conversation. I just made lots of changes and was about to submit a pullrequest, when I saw these comments! Looks like I wasted an hour.

@phl0 these changes you propose look great! Nice work!

@dg9vh I received emails from a user asking why they couldn't place 'E' at the end of the target for echo. I know this, but, not everyone understands what is going on. Either way, it was just a thought.

Thanks both! :) :+1:

phl0 commented 7 years ago

Ok then. Thanks for the feedback. I will PR it then.

phl0 commented 7 years ago

See https://github.com/dg9vh/MMDVMHost-Dashboard/pull/82

phl0 commented 7 years ago

Closed via 3ef43d7e2cceca89609994c1ccb8d75ef71573c0