Closed petzsch closed 1 year ago
With @petzsch we noticed that two payment methods failed (because full node unavailable), but those were still added to the invoice with null value.
@petzsch supposes it is because of lazy payments. I think he is right, as CreateInvoiceCore
shouldn't do this.
{
"cryptoData": {
"BTC_LightningLike": {
"rate": 100000000.0,
"paymentMethod": {
"BOLT11": null,
"PaymentHash": null,
"InvoiceId": null,
"NodeInfo": null,
"Activated": false
},
"feeRate": null,
"txFee": null,
"depositAddress": null
},
"BTC": {
"rate": 100000000.0,
"paymentMethod": {
"activated": false,
"networkFeeMode": 0,
"networkFeeRate": null,
"payjoinEnabled": false,
"keyPath": null
},
"feeRate": null,
"txFee": null,
"depositAddress": null
}
}
}
Ping @Kukks
This is a bug from BTCpay Server actually.
Transfered to https://github.com/btcpayserver/btcpayserver/issues/4289
Note this issue had another bug related to NBX: NBX is asking for the full mempool upon connecting to a node. But the mempool is so big that it would stall the sync completely.
I removed this on https://github.com/dgarage/NBXplorer/commit/f063979667e533042c84748143dc316dbee46774
The issue hopefully permanently resolved after a btcpay restart. Running on a RPI4 8GB with native btcpay docker deploy.