search

dgarijo / Widoco

Wizard for documenting ontologies. WIDOCO is a step by step generator of HTML templates with the documentation of your ontology. It uses the LODE environment to create part of the template.
Apache License 2.0
295 stars 89 forks source link

Copy resources directly without zip #653

Closed vChavezB closed 11 months ago

vChavezB commented 11 months ago

Instead of using zip files, use the source files in the resources directory. This allows to track differences easily over git as zip files cannot be compared between commits easily.

In specific I did this as I am testing the swrl rules xslt files (see #652 ) and found out that the zip file is used instead of the src/main/resources/lode folder.

dgarijo commented 11 months ago

@vChavezB thanks! Can you please merge in develop It's the branch where the latest changes are

vChavezB commented 11 months ago

I have changed it to the develop branch. Should I also delete the webvowl patched zip and display the source files ? At the moment I tested my changes only with the resources from the folder loder and oops.

dgarijo commented 11 months ago

We should be consistent, so yes, if it's not a lot of effort, let's do that. Having to create the zip file every time is less ideal.

vChavezB commented 11 months ago

updated 👍

dgarijo commented 11 months ago

This looks good to me. I'll have to check if those getAbsolutePaths do are not problematic in unix. Thanks! Please add yourself as well in the contributor list in the README file

dgarijo commented 11 months ago

Ouch, no, it does not pass the tests. I will leave a few comments where the errors may be

vChavezB commented 11 months ago

Thanks for the feedback. I think I did not push the changes for those files correctly. Will have a look again ;)

dgarijo commented 11 months ago

Still not :(

vChavezB commented 11 months ago

Sorry for the multiple changes. I must admit that Java is not my first language.

I will do a clean git clone and compile again to debug this.

dgarijo commented 11 months ago

No rush

vChavezB commented 11 months ago

Ok I think it should now compile, for some reason the previous commit did not use the copyResourceDir method.

dgarijo commented 11 months ago

Thanks, looking good. Will review and merge soon!