search

dgarijo / Widoco

Wizard for documenting ontologies. WIDOCO is a step by step generator of HTML templates with the documentation of your ontology. It uses the LODE environment to create part of the template.
Apache License 2.0
287 stars 88 forks source link

bugfixes #690

Closed SirkoS closed 6 months ago

SirkoS commented 6 months ago

Hi,

I fiddled around with Widoco today and caught a few issues I consider bugs. The three commits each target one of the following:

  1. Dark Mode: namespace table still used light mode styling
    • I added the CSS variables in the respective CSS file also for the table style
  2. -noPlaceHolderText overrides manually set paths to abtract etc
    • It could be argued that this is intended behavior but I'd consider this a bug. As a user I only want to prohibit placeholders and not the texts I explicitly set.
    • I changed the behavior so that the config file's pathToAbstract etc supersede -noPlaceHolderText. Now, only the text that are not set are hidden.
  3. When using -uniteSections, some marked JavaScript failed.
    • I assume this was just missed when updating marked at some point. It was already fixed in one place but left open in two other places.

If need be, I can also make this 3 separate pull requests but for me it was easier to include all my fixes into one.

cheers, Sirko

PS: it would be really nice if these were included in a bugfix release, so I can use it directly in my CI/CD pipelines. PPS: I'm sorry for the extensive whitespace changes. My editor is just configured to trim upon save.

dgarijo commented 6 months ago

@SirkoS thanks a lot!! Next time please push your changes into the develop branch, as it's the latest one. Since I did a release last week these are now in sync, but in the future they may be not.

dgarijo commented 6 months ago

Published a new release with your fixes @SirkoS