search

dgarlitt / karma-nyan-reporter

Nyan Cat style reporter based on the Mocha version
MIT License
169 stars 19 forks source link

maxLogLines flag for configuration #25

Closed whyboris closed 7 years ago

whyboris commented 7 years ago

Added a flag to user configuration to limit the number of lines of failed test to log

      // limit the number of lines of error shown
      // No error occurs if this limit is longer than 
      // the number of lines reported.
      maxLogLines: 5 // default is 9001

Warning, the test.js files have not been updated.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 99.72% when pulling ee755271d68e6cea7af6db5a1bdd244190a6932d on whyboris:maxloglines into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 99.72% when pulling 46e3a86b16271156df0d2c40e36a7896b410aede on whyboris:maxloglines into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 1e80d3423c9d4ca04ff94ac3e8322f4d41032e52 on whyboris:maxloglines into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

whyboris commented 7 years ago

Please feel free to commandeer my PR and change whatever you see fit.

I am unsure if some of the tests I added are very useful. Also I was unable to cover the else path on a conditional I wrote -- decreasing your branch coverage.

I'm happy to update the PR with more feedback from you; thank you for the explicit suggestions before.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 82c4559f86f277680446b5f015dd042083f1d7f9 on whyboris:maxloglines into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

whyboris commented 7 years ago

I recommend closing this PR in lieu of https://github.com/dgarlitt/karma-nyan-reporter/pull/33