search

dgarlitt / karma-nyan-reporter

Nyan Cat style reporter based on the Mocha version
MIT License
169 stars 19 forks source link

Permit users to customize error report colors #29

Closed whyboris closed 7 years ago

whyboris commented 7 years ago

Permit users to customize the colors for the error report via reporter settings:

      // set custom color options for error report
      // will only work with numbers permitted in
      // https://github.com/medikoo/cli-color
      colorOptions: {
        testName: 0,  // default is 205
        browserName: 120, // default is 199
        firstLine: 255 // default is 211
      }

Please let me know if there is a good reason to keep the clc.red( or clc.yellow( rather than colors defined by numbers.

As before, once I get feedback that my implementation is good, I will write all appropriate tests.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-20.0%) to 80.0% when pulling 2fccc4e3c51463eeac5b0b6e762f330ff1b53fb8 on whyboris:usercolorsettings into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

whyboris commented 7 years ago

I recommend closing this PR in lieu of https://github.com/dgarlitt/karma-nyan-reporter/pull/33