Numerous user settings added - Githubissues

dgarlitt / karma-nyan-reporter

Nyan Cat style reporter based on the Mocha version

MIT License

169 stars 19 forks source link

Numerous user settings added #33

Open whyboris opened 7 years ago

whyboris commented 7 years ago

Major changes

all package versions updated to May 2017
- cli-color now allows color nesting

Bugfixes

error report counter resets to 1 on subsequent run (https://github.com/dgarlitt/karma-nyan-reporter/issues/31)
don't hide errors that occur (https://github.com/dgarlitt/karma-nyan-reporter/issues/26)
- Angular 2 template parse errors no longer hidden

User options

colors for error report
exclude from error report lines that contain user-chosen strings
underline all filenames of any user-chosen filetype
hide browser version information from error log
clear screen before every run

Minor improvement

new rainbow:

‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--
‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--
‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--
‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--

A diff for passing tests, 100% coverage, and more tests for added functionality coming

coveralls commented 7 years ago

Coverage decreased (-26.0%) to 74.005% when pulling 3a0c107b7717355bccdffdc00a8e64317a9bb8ed on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage decreased (-7.5%) to 92.506% when pulling 5dce68b365b584277ce6a3c27c7e8c50fb749a1e on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage decreased (-7.03%) to 92.974% when pulling 81ebc137ffca7146b12e2d4f45962611c5006200 on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage decreased (-3.7%) to 96.253% when pulling 8f33ff2ecadd81ba430b42dfe4860f3b3d27fba6 on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage decreased (-1.6%) to 98.361% when pulling a12b8f4f28b87cef84ea585feafa95eac1a1ef52 on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage decreased (-0.7%) to 99.297% when pulling 90bc1e78885d86f2bfc4062da3b3f9ea3c652e32 on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage decreased (-0.7%) to 99.297% when pulling dbfc1e87bd545b9f185c9af2256e03f8bb5cb36e on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling bd5f73dd1283c4fe080e43a2ac75675e6edcd963 on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling bd5f73dd1283c4fe080e43a2ac75675e6edcd963 on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling bd5f73dd1283c4fe080e43a2ac75675e6edcd963 on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling bd5f73dd1283c4fe080e43a2ac75675e6edcd963 on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling bd5f73dd1283c4fe080e43a2ac75675e6edcd963 on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling bd5f73dd1283c4fe080e43a2ac75675e6edcd963 on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling bd5f73dd1283c4fe080e43a2ac75675e6edcd963 on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling bd5f73dd1283c4fe080e43a2ac75675e6edcd963 on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling bd5f73dd1283c4fe080e43a2ac75675e6edcd963 on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

whyboris commented 7 years ago

Please let me know if you would like to assimilate the functionality I am trying to add in this PR before I spend more time fixing tests (there are a few left).

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 99.774% when pulling 85cd42a13da61037968e74f732a23cd8328c6dbc on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling b27b42ee34ad36d32a4ac52f7e4b14ce9400d44e on whyboris:nyannyan into 68da8261defe424c4ecf7805034f2de778c06d96 on dgarlitt:master.

dgarlitt commented 7 years ago

@whyboris I would rather go back to addressing each of these additions individually. I have procrastinated on this for a while because there are several items I'd like to discuss. It seems like the open issue items (template parse errors in Angular 2 and numbering) are more important, so if you could open a single pull request for those, that would be great. Then we can address the remaining items one at a time.

The main items that I'd like to discuss are

exclude from error report lines that contain user-chosen strings
underline all filenames of any user-chosen filetype
new rainbow

But, again, it would be nice to address your open issues (#26 & #31) by itself, first.

whyboris commented 7 years ago

Thank you for your willingness to include changes into your project. I'll extract the functionality from this PR and break it into pieces. I'll create a single pull request addressing these two:

Template parse errors in Angular 2 (https://github.com/dgarlitt/karma-nyan-reporter/issues/26)
Reset numbering of tests on each re-run (https://github.com/dgarlitt/karma-nyan-reporter/issues/31)