search

dgasmith / gau2grid

Fast computation of a gaussian and its derivative on a grid.
https://gau2grid.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
29 stars 17 forks source link

Add soversion to gau2grid library #24

Closed susilehtola closed 6 years ago

susilehtola commented 6 years ago

I need to get this packaged in Fedora so that I can finally update psi4 to the 1.2 series.

However, gau2grid doesn't have an soname, which should be added. https://fedoraproject.org/wiki/Packaging:Guidelines#Downstream_.so_name_versioning

loriab commented 6 years ago

As mentioned, I hate redundant info, and tying SOVERSION to package version seems to me to be just that, as well as skipping over the original intention of the former. Will #28 work for your needs?

susilehtola commented 6 years ago

Definitely. I really dislike version based sonaming which forces rebuilding packages all the time.

Susi Lehtola Sent from my phone so excuse my brevity.

On 22 Oct 2018, at 19.16, Lori A. Burns notifications@github.com<mailto:notifications@github.com> wrote:

As mentioned, I hate redundant info, and tying SOVERSION to package version seems to me to be just that, as well as skipping over the original intention of the former. Will #28https://github.com/dgasmith/gau2grid/pull/28 work for your needs?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/dgasmith/gau2grid/issues/24#issuecomment-431901999, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AArOJ5PaOYFe9ElXwVljkJ_h6SfYSNllks5unf0ugaJpZM4W1dmf.

dgasmith commented 6 years ago

Merged in thanks!