dgasmith / gau2grid

Fast computation of a gaussian and its derivative on a grid.

https://gau2grid.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

29 stars 15 forks source link

Moves from `_mm_malloc` to `aligned_alloc` where possible. #27

Closed dgasmith closed 6 years ago

dgasmith commented 6 years ago

Appears Mac clang does not have full c11 support (no aligned_alloc). Also, MSVC requires a special _aligned_malloc. Should address #25.

codecov-io commented 6 years ago

Codecov Report

Merging #27 into master will increase coverage by <.01%. The diff coverage is 85.71%.

dgasmith commented 6 years ago

@andysim Any better ideas on how to do this?

andysim commented 6 years ago

Sadly not. My instinct is to see what the excellent MIPP package does, and they use mm_alloc. I rolled my own allocator (well, copied code from Josutis) but really don't recommend that and I think your solution is much better. I'll be getting rid of my allocator when I start using MIPP for that project.

dgasmith commented 6 years ago

Rough, this is in response to #25. Thanks for looking.