dgasmith / gau2grid

Fast computation of a gaussian and its derivative on a grid.

https://gau2grid.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

29 stars 15 forks source link

python looks for .so, not .so.1 #36

Closed loriab closed 5 years ago

loriab commented 5 years ago

[x] thank goodness py on mac looks for .so, not .dylib. Win is probably still in trouble. using .so in py instead of so.1
[x] at @dgasmith suggestion, fix intel compilers (broken since #27) by adjusting pragmas
[x] make sure c code regenerates with changes to py generating code

codecov-io commented 5 years ago

Codecov Report

Merging #36 into master will not change coverage. The diff coverage is n/a.

dgasmith commented 5 years ago

I don't think we are testing the CMake build/install. Can you provide an example that installs via CMake rather than setup.py?

loriab commented 5 years ago

I think this is ready for consideration. conda-build is happy on Linux. Should still fix the below. Since cmake underlies setup.py, is a separate example really useful?

Ah, Win was broken anyways: https://github.com/dgasmith/gau2grid/blob/master/appveyor.yml#L28

loriab commented 5 years ago

superceded by #37