Closed dgasmith closed 3 years ago
Thanks for the review @jcmgray. I think this is moving in the right direction, but we will need to revisit the typing interface for some of the more complex areas (dynamic programming, the diverse input types into contract, etc) before we put out a release.
Description
Bumps minimum python version to 3.6 according to NEP 29. We should bump to 3.7, but many libraries (torch!) are relatively slow to deprecate python versions, this seems like a reasonable compromise which allows us to type the library.
Questions
np.ndarray
meaning all interfaces should usenp.asanarray
upon call to convert tonp.ndarray
types. It doesn't seemasanyarray
is typed yet in the docs. Considering leaving these as Any as well since we tend to pass the base type through (called Tensor classes). Any guidance here?Todos
Notable points that this PR has either accomplished or will accomplish.
Status