dgasmith / opt_einsum

⚡️Optimizing einsum functions in NumPy, Tensorflow, Dask, and more with contraction order optimization.
https://dgasmith.github.io/opt_einsum/
MIT License
848 stars 68 forks source link

Python Type Annotations #161

Closed dgasmith closed 3 years ago

dgasmith commented 3 years ago

Description

Bumps minimum python version to 3.6 according to NEP 29. We should bump to 3.7, but many libraries (torch!) are relatively slow to deprecate python versions, this seems like a reasonable compromise which allows us to type the library.

Questions

Todos

Notable points that this PR has either accomplished or will accomplish.

Status

codecov[bot] commented 3 years ago

Codecov Report

Merging #161 (df6149e) into master (227c76b) will increase coverage by 0.41%. The diff coverage is 100.00%.

dgasmith commented 3 years ago

Thanks for the review @jcmgray. I think this is moving in the right direction, but we will need to revisit the typing interface for some of the more complex areas (dynamic programming, the diverse input types into contract, etc) before we put out a release.