dgasmith / opt_einsum

⚡️Optimizing einsum functions in NumPy, Tensorflow, Dask, and more with contraction order optimization.
https://dgasmith.github.io/opt_einsum/
MIT License
822 stars 67 forks source link

Github identifier format in docs/source/conf.py #230

Closed NGC2023 closed 15 hours ago

NGC2023 commented 2 months ago

Hi, I'm currently working on packaging opt_einsum v3.3.0 for Debian. While reviewing the code, I noticed an issue with the Github identifier format in docs/source/conf.py. I've prepared a patch to address this problem.

--- a/docs/source/conf.py +++ b/docs/source/conf.py @@ -395,8 +395,8 @@ def setup(app): app.connect('autodoc-skip-member', autodoc_skip_member)

extlinks = { -- 'issue': ('https://github.com/dgasmith/opt_einsum/issues/%s', 'GH#'), -- 'pr': ('https://github.com/dgasmith/opt_einsum/pull/%s', 'GH#') ++ 'issue': ('https://github.com/dgasmith/opt_einsum/issues/%s', 'GH#%s'), ++ 'pr': ('https://github.com/dgasmith/opt_einsum/pull/%s', 'GH#%s') }

dgasmith commented 2 months ago

@NGC2023 Thank you for the report, fortunately we have moved to mkdocs which has removed these files. We are currently preparing for another release.