search

dgbowl / tomato

tomato: au-tomation without the pain!
https://dgbowl.github.io/tomato
GNU General Public License v3.0
5 stars 6 forks source link

jobs don't 'complete with error' when start_job fails #81

Open g-kimbell opened 4 months ago

g-kimbell commented 4 months ago

When starting a job, if the biologic says it is in state "RUN" the job never starts, and it never switches to 'ce' (completed with error), it stays in a frozen running state and has to be manually cancelled.

The same happens if an error is thrown by drivers.biologic.start_job (e.g. there is a problem with the payload or the firmware isn't loaded), the job stays frozen and running.

PeterKraus commented 2 months ago

I think in general, we need to be more thorough about catching exceptions, logging them, and trying to recover.