search

dgcnz / dl2

Code for "Effect of equivariance on training dynamics"
1 stars 0 forks source link

debug/fix broadcasting issue when mse_loss #58

Closed dgcnz closed 1 month ago

dgcnz commented 1 month ago

Image

dgcnz commented 1 month ago

I think it's this:

https://github.com/dgcnz/dl2/compare/add-gconv-configs...main#diff-7969dd126a37fbff91b78d72837076049d02cefbb2fcb99086d87e4af67b6165R94-R104

https://github.com/dgcnz/dl2/blob/b18247ac4ed4c389a6e93e6e75746a6377688387/src/models/wang2022_module.py#L96-L104

Nesta-gitU commented 1 month ago

Why? arent both mse and weight_constrained 1 dimensional tensors

dgcnz commented 1 month ago

Done by @Nesta-gitU on https://github.com/dgcnz/dl2/commit/a6fb531809962958328fe291bd6f39a358265e0d