dgerosa / precession

Dynamics of spinning black-hole binaries with python
davidegerosa.com/precession
MIT License
31 stars 15 forks source link

not returning full output in remnantkick() #24

Closed reddtako closed 11 months ago

reddtako commented 1 year ago

When calculating kick velocity using remnantkick(... , full_output = True) the code reutrns an error :

"all input arrays must have the same shape"

It seems to me that this can be fixed by changing the line 6083

from : " return np.stack([vk, kick]) " to : " return vk, kick"

mdmould commented 1 year ago

Thanks for pointing this out. I've proposed a fix in https://github.com/dgerosa/precession/pull/27.

dgerosa commented 11 months ago

Thanks! Merged in version 2.0.4