dgets / DOCshell

Damo's version of the DOC (Citadel-esque) shell, in JavaScript, for use with Synchronet 3.14+ systems
https://www.pivotaltracker.com/n/projects/1206002
4 stars 1 forks source link

Duplicate code in stripNRead() in dperroom.js and stripComments() in dperuser.js? #157

Closed dgets closed 9 years ago

dgets commented 9 years ago

It looks an awfully lot like this code might be completely redundant. Being as stripNRead() is being deprecated and phased out since we're not going to be needing anything like this (at this point) anyway, I think it's probably a great reason to go with issue #133 and just leave this one method still available if comments might need to be stripped from a file. Honestly I don't think that any of these JSON files are ever going to be read or written by humans, though; they should be just fine without any sort of parsing for comments or anything. The code is going to take care of those files more than anything else.