dgets / DOCshell

Damo's version of the DOC (Citadel-esque) shell, in JavaScript, for use with Synchronet 3.14+ systems
https://www.pivotaltracker.com/n/projects/1206002
4 stars 1 forks source link

Recycling through the message bases repeatedly breaks ddoc2.js #245

Open dgets opened 8 years ago

dgets commented 8 years ago

While pounding the spacebar to make sure that the behavior I liked was sticking while working on issue #215, eventually I got an unhandled exception error due to the fact that msg_area.sub[user.cursub].name was undefined on line 747 of ddoc2.js. Going to wrap this in a try/catch loop and see if I can't find out some more details about it. Not sure if I should revert and find another bit to work on with #215 or if I should fix this and keep plugging away in this direction right now.

dgets commented 8 years ago

ddoc-go-boom

Ugh. Throwing my own exception doesn't work here, nor does manually resetting user.cursub. I'm not sure what the hell to do on this other than that complete rewrite. As you can see scan pointers are blown and I believe that it's also reading out of different message bases that it shouldn't have access to. All of this just from hitting spacebar 10-15 times to cycle through the message bases.

dgets commented 8 years ago

I'm starting to think that this might have to do by recursive calls opening mBase objects before they've closed the last instance of it opening. Might be a good idea to run through a check on all of the different opens and make sure that they're closed before passing to another method.