search

dgets / DOCshell

Damo's version of the DOC (Citadel-esque) shell, in JavaScript, for use with Synchronet 3.14+ systems
https://www.pivotaltracker.com/n/projects/1206002
4 stars 1 forks source link

Fully Modularize Message Entry #4

Closed dgets closed 9 years ago

dgets commented 10 years ago

Get that shit broken up. Seriously.

Create a new object to base the handling routines in, separate, and apply properly. Got to get out of this habit of writing linearly.

dgets commented 10 years ago

Starting to work on this has, of course, began introducing all sorts of bugs into the message entry routine that I had worked past previously. I suppose I should be looking at this as a good thing, as much more navigation of the OO structure of the code now is giving me a great opportunity to brush up on this. ;)

dgets commented 10 years ago

Going to work on using the different text input functionality made possible under the Synchronet API that have come to my attention since first starting on this bit today.

dgets commented 10 years ago

Many fixes have finally been pushed; I haven't gotten everything working that I had fixed this morning before the massive code loss just prior to attempting to commit, but much more modularization has taken place, redundant code has been removed, etc...

dgets commented 10 years ago

Now that I've finally gotten a chance to work on this again, I'm seeing that there is a bug in the looping structure that I'm utilizing in order to provide omnidirectional scanning through the message subs. The if (forward) clause leading towards a while loop that goes in either direction does not support the rcChoice command changing read direction from the message read sub-menu. Thus, there will have to be an external looping structure put around this, with a flag involved, if I can't actually sit and come up with the appropriate structure for handling this.

Having this long of a break from coding is definitely affecting my ability to hold the code in my head and my ability to concentrate fully on the issues with it... I could swear I'm actually getting rusty with some of the methodology that I was just using not too long ago, as well. I need to make sure that I'm doing a little bit of coding each night.

dgets commented 10 years ago

To expound on what was written before, it looks like scanSub() and uniMsgRead() will replace a good portion of what now exists in msg_base.entry_level.newScan(); I'm not sure if this code is duplicated anywhere else. It will provide the functionality for whatever behavior is necessary in the scanning and reading code, though, via parameters passed.

This will complete the message handling modularity, for now.

dgets commented 9 years ago

As everything left for this is primarily being debugging in the OO structural issues and handled via different issues, I'm closing this issue.