Not quite sure, upon code review, what analytics.Offense.scan_for_enemy_shipyards() is doing, aside from the scanning for enemy shipyards that it's supposed to. It is also playing with ship destinations, and was definitely horking a few of them due to continuing to process all ships beyond the 4 that were required in order to keep up a blockade around each other player's shipyard.
Code needs a walk-through in order to determine where, exactly, this method is being run from. It may be alright now, though the logic, if it is setting ship destination information and the other stuff, should be separated, double checked, and fixed.
Not quite sure, upon code review, what
analytics.Offense.scan_for_enemy_shipyards()is doing, aside from the scanning for enemy shipyards that it's supposed to. It is also playing with ship destinations, and was definitely horking a few of them due to continuing to process all ships beyond the 4 that were required in order to keep up a blockade around each other player's shipyard.Code needs a walk-through in order to determine where, exactly, this method is being run from. It may be alright now, though the logic, if it is setting ship destination information and the other stuff, should be separated, double checked, and fixed.