search

dgets / nightMiner

Halite III Bot - rewriting Halite III bot from scratch with better project structure plans
6 stars 1 forks source link

Don't forget to prune dead ships from the current_assignments #8

Closed dgets closed 5 years ago

dgets commented 5 years ago

Right now dead ships are just hanging out in there. I'm not sure which way would be more efficient to do things, honestly; I just don't know enough about py3's internals to make an educated guess on that, but I think it'd be best to prune them in case traversing the history for things ever becomes necessary.

If deep learning ever has to go over a history of that data, that will be immensely useful, as well.

dgets commented 5 years ago

Do log analysis to find out if this can be closed or not.

dgets commented 5 years ago

After log analysis, it appears that ships are correctly being pruned from the current_assignments when they collide and perish. However, there is still an issue in pruning from current_assignments after they make a drop of halite. Not sure what's going on here, but I'll try to mark the relevant places in the last commit, tagging them in this issue.

dgets commented 5 years ago

See: no workee: https://github.com/dgets/nightMiner/blob/d9b43f9dc70d4f70c33c9f62f96f3a5349ed2076/nightMiner.py#L107

workee: https://github.com/dgets/nightMiner/blob/d9b43f9dc70d4f70c33c9f62f96f3a5349ed2076/nightMiner.py#L128

wherein, before processing, both lists are concatenated via: https://github.com/dgets/nightMiner/blob/d9b43f9dc70d4f70c33c9f62f96f3a5349ed2076/nightMiner.py#L131

...and yes, I will be adding debugging log output to check the content of these two lists prior to concatenation just as soon as I get another minute to focus on code here.

dgets commented 5 years ago

Handled.