search

dgibson / dtc

Device Tree Compiler
235 stars 134 forks source link

Multiple-definition of fdt target in Meson definitions #106

Open ernestask opened 1 year ago

ernestask commented 1 year ago

When configuring the project with Meson, this is the result:

Tried to create target "fdt", but a target of that name already exists.

https://www.spinics.net/lists/devicetree-compiler/msg03863.html would have fixed it, but it was never accepted. The concern was that removing the duplicate target would somehow make Meson not spit out targets for both the shared and static library, but, as Marc-André explained, this should be set through the default_library option. both is a valid setting.

ernestask commented 1 year ago

Moreover, there should probably be an Actions workflow to perform a test-build with Meson.

ernestask commented 1 year ago

https://mesonbuild.com/Builtin-options.html#core-options

dgibson commented 1 year ago

Ugh. The unfortunate truth is that the meson stuff was applied by someone else, I don't really have the knowledge to maintain it, nor the time to learn what I need.

@elmarco any chance you could look into this?

dgibson commented 1 year ago

Also, it would be good to have github actions for lots of things, including this. Learning how to write and use github actions is another thing I really haven't had time for.

ernestask commented 1 year ago

Since I’m currently toying with an old project that uses libfdt, I could look into implementing at least some of those wishlist items.

dgibson commented 10 months ago

I think this was fixed by this commit. @ernestask, could you verify?