search

dgibson / dtc

Device Tree Compiler
235 stars 134 forks source link

pylibfdt: Use python.extension_module() #109

Closed ernestask closed 1 year ago

ernestask commented 1 year ago

This commit avoid using deprecated setuptools utilities and builds the module directly using Meson.

ernestask commented 1 year ago

I did some quick sanity checking by replacing the module and running make check, but it turns out that https://github.com/dgibson/dtc/pull/108 (the issue fixed by it) was causing tests to not run.

dgibson commented 1 year ago

With this patch meson builds fail for me with lots of errors from swig.

We also still get warnings when building with make because of deprecated setuptools. I'd prefer to avoid diverging how the module is built between make and meson if we can.

ernestask commented 1 year ago

The thing about build systems is that they are not supposed to mimic one another. If you want to use Meson like Make, then it’s best to drop support for it.

ernestask commented 1 year ago

But feel free to close this if you disagree, I can maintain a fork with these changes.

dgibson commented 1 year ago

The thing about build systems is that they are not supposed to mimic one another. If you want to use Meson like Make, then it’s best to drop support for it.

It's not a question of wanting to use meson like make, it's a question of (confidently) producing similar results. What I'm worried about here is the possibility of subtle incompatibilities in the python package as produced by meson versus as produced by setuptools.