search

dgibson / dtc

Device Tree Compiler
215 stars 127 forks source link

pylibfdt/Makefile.pylibfdt: use project's flags to compile the extension #139

Closed sharkcz closed 3 weeks ago

sharkcz commented 1 month ago

Seems the project's CFLAGS are not used when compiling the python extension's C code via the setup.py script. Some default flags are used instead. Thus pass the CFLAGS explicitly. Unfortunately the SWIG generated code is not clean and requires -Wno-error override to compile successfully, because -Werror is used in the project's flags.

sharkcz commented 1 month ago

IIRC meson managed builds are doing the right thing already.

dgibson commented 3 weeks ago

Merged, thanks.