search

dgidb / dgidb-v5

Providing interactions between drugs and genes sourced from a variety of publications and knowledgebases
https://dgidb.org
MIT License
14 stars 2 forks source link

feat: make 404 page global error page and have unrecognized paths rou… #500

Closed katiestahl closed 2 months ago

katiestahl commented 3 months ago

…te to it

close #396 close #460

mcannon068nw commented 2 months ago

This looks good as it. I do think its a little odd that the entire length of the line is clickable as a link but I don't think that it make or breaks this fix.

katiestahl commented 2 months ago

Also approving this in principle but a few things stuck out to me that might be worth thinking about

  1. the boxes for the links extend the entire width of the page for some reason? so if you click in the whitespace way to the right it still clicks a link. I think I'd expect the anchor to be on the text, not on the div surrounding the text
Screenshot 2024-05-25 at 9 39 09 PM
  1. how would it look if the back/home links were also in the red box, underneath the icon/message?
  2. I don't think a 404 HTTP response status gets sent -- that should probably be happening, assuming it's possible

side note: look at how fun the UniProt 404 icon is: https://www.uniprot.org/proteomdes?query=*

  1. good catch, I was going to fix this super quick but this looks like it's a weird MUI thing. I may create a new issue for it since it'll require a bit more digging into
  2. I like how this looks, so I changed it, ty for the suggestion!
  3. I think I'll create a new issue for this as well; I hope that's okay!

Also wow I love that 404 icon.