search

dgilland / omdb.py

Python wrapper around OMDb API (Open Movie Database): http://omdbapi.com
http://omdbpy.readthedocs.org
Other
98 stars 23 forks source link

Fixed Python 3 compatiblity and cleaned up code for PEP 8 compliancy #1

Closed agronholm closed 10 years ago

agronholm commented 10 years ago

Fairly straightforward Python 3 port, with code cleanups added, plus tox and wheel configuration thrown in.

dgilland commented 10 years ago

Thanks for this! It's much appreciated!

dgilland commented 10 years ago

I went ahead and released these changes in v0.1.1: https://pypi.python.org/pypi/omdb/0.1.1

agronholm commented 10 years ago

Thanks!

agronholm commented 10 years ago

One more thing -- a wheel would be a nice addition too.

$ pip install wheel
$ python setup.py bdist_wheel upload
dgilland commented 10 years ago

Done: 3d59f2fb6f0637f804f12cce74f7e62ef9dc2ecb

and uploaded to pypi.

agronholm commented 10 years ago

I just noticed one tiny mishap I caused -- the "Programming Language :: Python" category is included twice in setup.py. Other than that, everything looks fine!

By the way, if you use twine tool to upload the wheel before the sdist, PyPI will list the dependencies on the project page. That information is not really used anywhere, it's just a "nice to have" that you can ignore if you want. Thanks again!

dgilland commented 10 years ago

Eh, no problem. I'll fix on next version.

Didn't know about twine. Looks interesting. I'll probably also include that on the next release too.

Thanks again for the code updates! You've definitely given me some new tools to use for this project and others (tox, wheel, and now twine).