search

dglazier / elSpectro

Event Generator for electron scattering hadron spectroscopy
GNU Lesser General Public License v2.1
1 stars 3 forks source link

Extra space in HepMC3 writer #7

Closed jrstevenjlab closed 3 years ago

jrstevenjlab commented 3 years ago

I just found there's an extra space in this line https://github.com/dglazier/elSpectro/blob/master/core/HepMC3Writer.h#L48

after the "E " which prevents the eic-smear code reader for parsing it properly. I tried pushing a branch with a fix, but didn't have permission. Derek, could you remove this extra space?

Separately, for other fixes/modifications, should we setup permissions to push branches to this repository so we can execute pull requests, or should I do that from a forked repo?

dglazier commented 3 years ago

Hi Justin, I have given you permission to push to elspectro. To you want to see if it works for this fix? Cheers Derek

jrstevenjlab commented 3 years ago

Thanks, I submitted a PR which you can merge if you agree

On Jan 27, 2021, at 11:34 AM, dglazier notifications@github.com wrote:

Hi Justin, I have given you permission to push to elspectro. To you want to see if it works for this fix? Cheers Derek

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_dglazier_elSpectro_issues_7-23issuecomment-2D768409092&d=DwMCaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=nTWoLox3qePKkU3jkN4zKWpZiD5wwsYi6X23ArE2v3s&m=tnfUZu4LeeOzl0bGRFJ_RApws5XCV80FqPx5uNsyS1U&s=RWN7pLcRtibg0tfsek3ACSLmM-RVexRJPZz0ubU7yi0&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ADFBEBULBCDF4IP6N5DENILS4A6ABANCNFSM4WVRMQQA&d=DwMCaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=nTWoLox3qePKkU3jkN4zKWpZiD5wwsYi6X23ArE2v3s&m=tnfUZu4LeeOzl0bGRFJ_RApws5XCV80FqPx5uNsyS1U&s=etaA4LzCxiWzpKclGv0oj_oTdlI8tuTLo9eVCuOooN4&e=.

dglazier commented 3 years ago

Merged