dglee87 / get-simple-cms

Automatically exported from code.google.com/p/get-simple-cms
GNU General Public License v3.0
0 stars 0 forks source link

Hyperlink box doesn't have a field for the HTML title attribute anymore #330

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Key in some text into the Editor and select it, then click on the link button

2. In the opening box, try and find a text field in which to input text for the 
HTML title attribute

3. Be amazed at how this could get lost between 3.0 and 3.1x ;-)

What is the expected output? What do you see instead?
There should be a text field

What version of the product are you using? On what operating system?
GS 3.1.1, advanced editor setup

Please provide any additional information below.
From a SEO point-of-view the title attribute is important in order to convey 
context and/or more info about the link.

Original issue reported on code.google.com by drachenz...@gmail.com on 26 Jun 2012 at 4:56

GoogleCodeExporter commented 9 years ago
This could be added manually in the source view, but that's not really 
comfortable or practicable for customers.

Original comment by drachenz...@gmail.com on 26 Jun 2012 at 5:03

GoogleCodeExporter commented 9 years ago
I complained about the missing attributes as well.

you can fix this in your ckeditor config

admin/template/js/ckeditor/config.js

comment out the lines that say
advTab.remove( 'advTitle' );
for example.

It is preffered that you create your own config and specifty that in your 
gsconfig.
Copy that file and put it in your theme, make your changes there.
Then add this to your gsconfig to reflect where you put it.

define('GSEDITOROPTIONS',
customConfig : '../../../../theme/inovation/assets/js/cke_custom.js'
");

Original comment by tablatronics on 29 Jun 2012 at 3:28

GoogleCodeExporter commented 9 years ago
Title is not a required field, and its use is somewhat controversial with 
regards to SEO and accessibility.

Since this can be customer tweaked through configuration as I stated above it 
will not be fixed.

Original comment by tablatronics on 18 Jul 2012 at 4:15

GoogleCodeExporter commented 9 years ago
This was unexpected.

I can live with a bug or feature request being rejected with valid reasons, but 
this is not even remotely funny.

You're removing an omniscient HTML attribute and having customers jump through 
config file loops in order to get it back.

<shakes head>

Original comment by drachenz...@gmail.com on 18 Jul 2012 at 6:12