search

dglent / meteo-qt

System tray application for weather status information
GNU General Public License v3.0
83 stars 21 forks source link

No Setting option in right click menu in KDE Plasma 5 #34

Closed anexation closed 9 years ago

anexation commented 9 years ago

There is No Setting option in right click menu in KDE Plasma 5, how can i configure settings?

image

dglent commented 9 years ago

Hello, i don't know why you have only a 'Quit' option, and with a different icon than this: https://github.com/dglent/meteo-qt/blob/master/meteo_qt/images/application-exit.png.

I will install kde plasma 5 to investigate it, thanks for reporting.

anexation commented 9 years ago

i am the maintainer and lead developer of manjaro plasma 5 and wanted to included this in the iso.. an easy option to test develop is my iso if your interested..

https://forum.manjaro.org/index.php?topic=18150.0 https://sourceforge.net/projects/manjarotest/files/0.9.0/kf5-plasma-dev/

thanks for the quick replay.

AneX

dglent commented 9 years ago

Thank you, i installed it in the virtualbox. I could reproduce the issue. The problem is that the left click is recognized correctly and the middle click is recognized as right click

Here there is the list with the activation reasons: http://doc.qt.io/qt-5/qsystemtrayicon.html#ActivationReason-enum but in Plasma 5 (manjaro live) that i tested: the left click gives 3 the middle click gives 1 the right click gives nothing the program doesn't listen at all the right click

Instead i have a pop up with only the "Quit" menu, as you show in the screenshot, which doesn't belongs to the application.

I don't know what is the cause, in Plasma 5 or in pyqt5. Asuming that it works fine in lxqt, i suppose that something happen in Plasma 5 tray

Maybe i could apply a workaround for Plasma 5 but i don't know what exactly. The problem is with a mouse without a middle button

I will try to learn some more info about

dglent commented 9 years ago

Please can you test the last commit ? I tested in the virtualbox in manjaro using your images, with qt 5.4.0 and it is ok. It adds the context menu in the systemtray context menu of Plasma5

If it is ok for you i will release a new version

anexation commented 9 years ago

k, let me eat an make a -git version on aur then will test

anexation commented 9 years ago

Thank you very much, perfect.. https://aur.archlinux.org/packages/meteo-qt-git/

I will close this issue as solved..

dglent commented 9 years ago

Ok thanks, i will release the 0.4.4 during the day

anexation commented 9 years ago

thank you, i don't know what distro or desktop you use but thank you very much appriciated.. https://forum.manjaro.org/index.php?topic=18150.msg175105#msg175105

dglent commented 9 years ago

In the context menu there is a submenu 'Cities' where appear the extra configured cities, or a label "Empty list" In plasma5 it doesn't work, i don't have the submenu.

anexation commented 9 years ago

yes i can confirm that also

dglent commented 9 years ago

We have good news for this: https://codereview.qt-project.org/#/c/103280/2//ALL

If you have the possibility to test it please let me know.

anexation commented 9 years ago

humm

dglent commented 9 years ago

Finaly there is a new change for plasma5 system tray in qt which fixes the bug: https://codereview.qt-project.org/103280 I couldn't install my 64bit packages in virtualbox as i discovered that i cannot have 64bit guest ... I will have to build 32 bit package in the virtualbox with the above patch I hope to have the time to do it this week. If you have the possibility to test it please let me know

anexation commented 9 years ago

Will get back on this later stuff came up

dglent commented 9 years ago

Finally this is the fix: https://reviewboard.kde.org/r/122171/ i couldn't test it yet

anexation commented 9 years ago

been really busy getting all my apps on the plasma5 iso to have non -git flags for repo and can be superseded when arch starts maintaining those packages, and making the new public release v1 iso.

http://sourceforge.net/projects/manjarotest/files/0.9.0/kf5-plasma-dev/

dglent commented 9 years ago

For info: We still wait the patches to be applied in packages... In these qt5 sources the systemtray patch is not applied yet: http://download.qt.io/official_releases/qt/5.4/5.4.1/ Qt system tray patch: https://codereview.qt-project.org/#/c/103280/

I didn't check yet in which version of KDE this patch (if) is applied: https://git.reviewboard.kde.org/r/122171/diff/#index_header

mitya57 commented 9 years ago

@dglent The Qt fix will be in 5.4.2 (expected to be released this week). The KDE fix is in KDE Frameworks 5.7 (released three months ago).

dglent commented 9 years ago

Thanks for the info

dglent commented 9 years ago

Screenshot with the fix:

@mitya57 :+1: