dgobbi / vtk-dicom

A set of classes for using DICOM in VTK.
BSD 3-Clause "New" or "Revised" License
259 stars 94 forks source link

Querying within sequence requires first item to match #139

Closed dgobbi closed 7 years ago

dgobbi commented 7 years ago

The intent is to follow PS 3.4 C.2.2.2.6 "Sequence Matching":

If all the Item Key Attributes match, for at least one of the Items of the Attribute against which the match is performed, a successful match is generated. A sequence of matching Items containing only the requested Attributes is returned.

Currently, the implementation has a bug, and a match is not generated unless the first item is the one that matches. Furthermore, for private attributes, matches are generated even when the values do not match.

Important: check that dicomdump only returns matching items.

dgobbi commented 7 years ago

Fixed by c97446c.