search

dgokcin / binance-triangle-arbitrage

A short script for finding triangle arbitrage opportunities in Binance.
MIT License
10 stars 4 forks source link

parsing primary.txt #2

Open dlasher opened 4 years ago

dlasher commented 4 years ago

Any guidelines for how many entries can be in primary.txt? And/or how long each one has to be? 2, 3, 4 characters?

this file, as primary.txt will crash with the following error - "AttributeError: 'NoneType' object has no attribute 'encode'"

primary.txt:

ADA ALGO ATOM BAND BAT BCH BITCNY BNB BNT BSV BTC BTS BUSD COMP CRO DASH DOT EOS ETC ETH JST KNC LEND LINK LTC NEO OKB OMG ONT PAX QTUM SRM SXP TRX TUSD USDC USDT VET WAVES WETH WGRT XLM XMR XRP XTZ YFI ZEC ZIL ZRX

Thoughts?

dlasher commented 4 years ago

Remove XLM, and the list works... Strange?

dgokcin commented 4 years ago

@dlasher yes, definitely strange. I am using the same script in this gist. I tweaked it to use a text file for the primary coins since I wanted to make them parametric. So I have no idea about the limitations of the text file.

This is a work in progress and any help is appreciated 🙂 .

dlasher commented 4 years ago

primary.txt

I attached the primary.txt I'm using (top 250 coins by volume)

See if you can make that work?

dgokcin commented 4 years ago

@dlasher I can not reproduce your error, I can run the container successfully with this command:

 docker run -it -v "$(pwd)"/primary-2.txt:/app/primary.txt -e PUBLIC_KEY=<PUBLIC_KEY> -e SECRET_KEY=<SECRET_KEY> denizgokcin/binance-triangle-arbitrage:latest

Which OS are you using?