Add default $package_name value for SLES and openSUSE

dgolja / golja-gnupg

Puppet module for managing GnuPG package and public keys

Apache License 2.0

13 stars 46 forks source link

Add default $package_name value for SLES and openSUSE #11

Closed tampakrap closed 9 years ago

dgolja commented 9 years ago

Tnx Theo ... Would you mind to add also the rspec tests for this change ?

tampakrap commented 9 years ago

sure, on it

tampakrap commented 9 years ago

Added SUSE in the spec/class tests but not in the acceptance ones. I'd like to also suggest you the puppet_spec_facts module for the class rspec tests

tampakrap commented 9 years ago

anything else missing from my side?

dgolja commented 9 years ago

Hmmm optionally could you tell me which operating system releases are supported, so I can update metadata.json accordingly.

tampakrap commented 9 years ago

SLES 12 and openSUSE 13.2, but putting only SLES in metadata.json should be sufficient

dgolja commented 9 years ago

tnx i will release a new version tonight ... tnx again for the commit