search

dgolja / golja-gnupg

Puppet module for managing GnuPG package and public keys
Apache License 2.0
13 stars 46 forks source link

Trusted key #2

Closed wilrnh closed 10 months ago

wilrnh commented 9 years ago

Hey, this req adds a "trusted" parameter to the gnupg_key type that declares the key should be ensured in gnupgv's trustedkeys.gpg keyring, or not. There are a few ways I could've gone about this, including using a "keyring" parameter altogether instead, offering even more flexibility as to which keyring the key should be stored in. However, I opted for a pull request instead to discuss this. I could've also added entire new type/provider, eg., gnupg_trusted_key. Let me know what your think.

I haven't written any tests for this change, simply because I've never written spec tests for my modules before :O so I'll need to dig into that (some other night.)

Cheers, Will

dgolja commented 9 years ago

Hey thank you for the PR. Looks ok, but yes let's try to add the rspec tests. I can help you with that if needed.

Also would be good to add the additional tests for the system rspec.

In the meantime I will fix the travis errors in the master branch.

dgolja commented 9 years ago

I updated the travis config so I would recommend that you rebase your last commit. After that I can help you writing the tests.