dgolja / golja-gnupg

Puppet module for managing GnuPG package and public keys
Apache License 2.0
13 stars 47 forks source link

key type parameter uses unquoted string in ready which leads to reserved word errors #22

Open dschaaff opened 7 years ago

dschaaff commented 7 years ago

in the example below key_type is set private

gnupg_key { 'hkp_server_20BC0A86':
  ensure     => present,
  key_id     => '20BC0A86',
  user       => 'root',
  key_server => 'hkp://pgp.mit.edu/',
  key_type   => private,
}

which produces the error Use of reserved word: private, must be quoted if intended to be a String value

In our use we are now quoting private, e.g.

gnupg_key { 'hkp_server_20BC0A86':
  ensure     => present,
  key_id     => '20BC0A86',
  user       => 'root',
  key_server => 'hkp://pgp.mit.edu/',
  key_type   => 'private',
}

and the module is continuing to function as expected. Based on that I believe it just needs to be adjusted in the ready to be quoted as a string.

dgolja commented 7 years ago

tnx ... i will fix the example in the documentation

dschaaff commented 7 years ago

I can submit a pull request for it.

dgolja commented 7 years ago

sure if you can do that would be great.